Set ENABLE_MANAGED_USERS #ifdef on Android.

Set ENABLE_MANAGED_USERS #ifdef on Android.

TBR=nyquist@chromium.org,atwilson@chromium.org
BUG=244891
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235155

[Bernhard Bauer, 2013-11-11 14:36:09]

Please review. Thanks!

[Adrian Kuegel, 2013-11-11 14:50:53]

LGTM with one comment.

https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
File chrome/browser/managed_mode/managed_mode_url_filter.cc (right):

https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
chrome/browser/managed_mode/managed_mode_url_filter.cc:320:
contents_->hash_site_map.equal_range(GetHostnameHash(url));
Is this the fix for the issue Hagen reported here?
https://b.corp.google.com/issue?id=11283149
If yes, could you please add a bug for that to the CL?

[Adrian Kuegel, 2013-11-11 14:58:53]

On 2013/11/11 14:50:53, Adrian Kuegel wrote:
> LGTM with one comment.
> 
>
https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
> File chrome/browser/managed_mode/managed_mode_url_filter.cc (right):
> 
>
https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
> chrome/browser/managed_mode/managed_mode_url_filter.cc:320:
> contents_->hash_site_map.equal_range(GetHostnameHash(url));
> Is this the fix for the issue Hagen reported here?
> https://b.corp.google.com/issue?id=11283149
> If yes, could you please add a bug for that to the CL?

Just a small follow-up: It might also be a good idea to put the bugfix in a
separate CL, in case we may need to merge it to M32.

[Bernhard Bauer, 2013-11-11 15:15:27]

https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
File chrome/browser/managed_mode/managed_mode_url_filter.cc (right):

https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
chrome/browser/managed_mode/managed_mode_url_filter.cc:320:
contents_->hash_site_map.equal_range(GetHostnameHash(url));
On 2013/11/11 14:50:53, Adrian Kuegel wrote:
> Is this the fix for the issue Hagen reported here?
> https://b.corp.google.com/issue?id=11283149
> If yes, could you please add a bug for that to the CL?

No, this method is for content pack support (to be exact, finding out which
content pack sites a given URL belongs to), which isn't used yet. So I don't
think we need to merge it back.

[Adrian Kuegel, 2013-11-11 15:17:16]

On 2013/11/11 15:15:27, Bernhard Bauer wrote:
>
https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
> File chrome/browser/managed_mode/managed_mode_url_filter.cc (right):
> 
>
https://codereview.chromium.org/63423003/diff/1/chrome/browser/managed_mode/m...
> chrome/browser/managed_mode/managed_mode_url_filter.cc:320:
> contents_->hash_site_map.equal_range(GetHostnameHash(url));
> On 2013/11/11 14:50:53, Adrian Kuegel wrote:
> > Is this the fix for the issue Hagen reported here?
> > https://b.corp.google.com/issue?id=11283149
> > If yes, could you please add a bug for that to the CL?
> 
> No, this method is for content pack support (to be exact, finding out which
> content pack sites a given URL belongs to), which isn't used yet. So I don't
> think we need to merge it back.

Ok, thanks for the explanation :)

[Bernhard Bauer, 2013-11-11 15:30:09]

Remaining OWNERS TBR.

[commit-bot: I haz the power, 2013-11-11 15:31:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/63423003/1

[commit-bot: I haz the power, 2013-11-11 17:41:39]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[nyquist, 2013-11-11 17:47:41]

chrome/browser/android/ lgtm

[commit-bot: I haz the power, 2013-11-12 09:24:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/63423003/1

[commit-bot: I haz the power, 2013-11-12 19:48:47]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Andrew T Wilson (Slow), 2013-11-14 10:36:58]

lgtm

[commit-bot: I haz the power, 2013-11-14 11:33:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/63423003/470001

[commit-bot: I haz the power, 2013-11-14 11:53:39]

Retried try job too often on mac_rel for step(s) app_list_unittests,
cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, ipc_tests, jingle_unittests,
media_unittests, message_center_unittests, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-14 12:11:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/63423003/430002

[commit-bot: I haz the power, 2013-11-14 12:13:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/63423003/720001

[commit-bot: I haz the power, 2013-11-14 16:15:37]

Change committed as 235155