Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 6342: Specialized string equality based on representation (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

- Specialized slow-case string equality nine ways based on the underlying string representation of the two strings involved. - Renamed ascii and two byte string classes to sequential ascii and sequential two byte, and renamed IsAscii and friends to IsAsciiRepresentation. This is to make a clear distinction between strings with an ascii/two-byte representation, of which there is four, and flat sequential ascii/two-byte string.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -184 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codegen-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap.cc View 9 chunks +17 lines, -16 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 12 chunks +43 lines, -25 lines 6 comments Download
M src/objects.cc View 14 chunks +129 lines, -35 lines 0 comments Download
M src/objects-inl.h View 8 chunks +40 lines, -28 lines 0 comments Download
M src/runtime.cc View 5 chunks +12 lines, -74 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
12 years, 2 months ago (2008-10-08 12:08:04 UTC) #1
Erik Corry
http://codereview.chromium.org/6342/diff/1/8 File src/objects.h (right): http://codereview.chromium.org/6342/diff/1/8#newcode3168 Line 3168: inline int AsciiStringSize(Map* map); Needs renaming http://codereview.chromium.org/6342/diff/1/8#newcode3179 Line ...
12 years, 2 months ago (2008-10-08 12:59:53 UTC) #2
Erik Corry
12 years, 2 months ago (2008-10-08 13:05:00 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698