DidStopLoadingIcons should account for remote main frame.

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 9f42f03fc4174428ef5dd3b71a9ededc9ace26d1..7df9f89d6e0a9c41d0959cab828be108d2840ecd 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -4174,6 +4174,9 @@ void RenderViewImpl::DidStopLoadingIcons() {
   if (TouchEnabled())
     icon_types |= WebIconURL::TypeTouchPrecomposed | WebIconURL::TypeTouch;
 
+  if (webview()->mainFrame()->isWebRemoteFrame())

[Charlie Reis, 2014/10/08 19:18:38]

This is probably the right thing long-term, right?  I think Favicons / touch
icons only matter for the main frame, so it sounds right to ignore them when the
main frame is remote.

Can you put a comment to that effect?

[nasko, 2014/10/13 16:55:50]

Done.

+    return;
+
   WebVector<WebIconURL> icon_urls =
       webview()->mainFrame()->iconURLs(icon_types);