Use solid color layer for delegated surface.

Use solid color layer for delegated surface.

With delegated frames, we either want to display the frame itself or a single color (white). Default the layer for delegated frames to be solid color, and allow the layer to be switched from delegated to solid color when the delegated contents go away.

BUG=420832
Committed: https://crrev.com/f472c68723886e6f4878ce1214881faef492dc1d
Cr-Commit-Position: refs/heads/master@{#299353}

[jbauman, 2014-10-09 01:51:19]

jbauman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2014-10-09 06:30:27]

lgtm

https://codereview.chromium.org/634113002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/634113002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_aura.cc:1689:
DCHECK(false);
nit: NOTREACHED()

[jbauman, 2014-10-09 20:50:05]

jbauman@chromium.org changed reviewers:
+ sky@chromium.org

[jbauman, 2014-10-09 20:50:06]

Also sky@ for OWNERS review of ui/aura/* and ash/*

[sky, 2014-10-10 02:42:58]

https://codereview.chromium.org/634113002/diff/80001/ash/display/mirror_windo...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/634113002/diff/80001/ash/display/mirror_windo...
ash/display/mirror_window_controller.cc:116:
mirror_window->Init(aura::WINDOW_LAYER_SOLID_COLOR);
Why is solid color right here?

[jbauman, 2014-10-10 23:20:45]

On 2014/10/10 02:42:58, sky wrote:
>
https://codereview.chromium.org/634113002/diff/80001/ash/display/mirror_windo...
> File ash/display/mirror_window_controller.cc (right):
> 
>
https://codereview.chromium.org/634113002/diff/80001/ash/display/mirror_windo...
> ash/display/mirror_window_controller.cc:116:
> mirror_window->Init(aura::WINDOW_LAYER_SOLID_COLOR);
> Why is solid color right here?

This is only ever used to display either a TextureMailbox or temporarily reset
to be blank by the SetShowSolidColorContent in
ReflectorImpl::ReattachToOutputSurfaceFromMainThread or ReflectorImpl::Shutdown.
So it has no reason to display painted contents and doesn't need to be
WINDOW_LAYER_TEXTURED (also I'm removing SetShowPaintedContent in this patch, so
resetting it to show painted contents wouldn't work, and it needs to be reset to
show solid color contents instead, which only works on solid color layers).

[sky, 2014-10-13 16:53:01]

LGTM

[jbauman, 2014-10-13 19:32:16]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634113002/80001

[commit-bot: I haz the power, 2014-10-13 20:06:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-13 20:07:36]

Patchset 5 (id:??) landed as
https://crrev.com/f472c68723886e6f4878ce1214881faef492dc1d
Cr-Commit-Position: refs/heads/master@{#299353}