gpu/command_buffer/service/in_process_command_buffer.h - Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.h

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor

Patch Set: some build fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/resource_provider.cc ('K') | « gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h ('k') | gpu/command_buffer/service/in_process_command_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/in_process_command_buffer.h

diff --git a/gpu/command_buffer/service/in_process_command_buffer.h b/gpu/command_buffer/service/in_process_command_buffer.h

index e91d6f647371b1aeca3faa8083578a6de5a39352..65cf1ec92fb81fc13ef6fbbe74c8dddbcd05e67f 100644

--- a/gpu/command_buffer/service/in_process_command_buffer.h

+++ b/gpu/command_buffer/service/in_process_command_buffer.h

@@ -94,12 +94,15 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,

// GpuControl implementation:

virtual gpu::Capabilities GetCapabilities() override;

- virtual gfx::GpuMemoryBuffer* CreateGpuMemoryBuffer(size_t width,

- size_t height,

- unsigned internalformat,

- unsigned usage,

- int32* id) override;

- virtual void DestroyGpuMemoryBuffer(int32 id) override;

+ virtual int32 CreateImage(ClientBuffer buffer,

+ size_t width,

+ size_t height,

+ unsigned internalformat) override;

+ virtual void DestroyImage(int32 id) override;

+ virtual int32 CreateGpuMemoryBufferImage(size_t width,

+ size_t height,

+ unsigned internalformat,

+ unsigned usage) override;

virtual uint32 InsertSyncPoint() override;

virtual uint32 InsertFutureSyncPoint() override;

virtual void RetireSyncPoint(uint32 sync_point) override;