Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: content/common/gpu/gpu_messages.h

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor
Patch Set: address review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_messages.h
diff --git a/content/common/gpu/gpu_messages.h b/content/common/gpu/gpu_messages.h
index d9301c9cc7da69f8f61ca30447d5ddc96d234eff..0fb71fec65fb73e2f28bb021dd299237de27a166 100644
--- a/content/common/gpu/gpu_messages.h
+++ b/content/common/gpu/gpu_messages.h
@@ -265,8 +265,8 @@ IPC_MESSAGE_CONTROL5(GpuMsg_CreateViewCommandBuffer,
IPC_MESSAGE_CONTROL4(GpuMsg_CreateGpuMemoryBuffer,
gfx::GpuMemoryBufferHandle, /* handle */
gfx::Size, /* size */
- unsigned, /* internalformat */
- unsigned /* usage */)
+ gfx::GpuMemoryBuffer::Format, /* format */
+ gfx::GpuMemoryBuffer::Usage /* usage */)
// Tells the GPU process to destroy buffer.
IPC_MESSAGE_CONTROL2(GpuMsg_DestroyGpuMemoryBuffer,
@@ -590,17 +590,17 @@ IPC_MESSAGE_ROUTED2(GpuCommandBufferMsg_SignalQuery,
uint32 /* query */,
uint32 /* signal_id */)
-// Register an existing gpu memory buffer. The id that can be
-// used to identify the gpu memory buffer from a command buffer.
-IPC_MESSAGE_ROUTED5(GpuCommandBufferMsg_RegisterGpuMemoryBuffer,
+// Create an image from an existing gpu memory buffer. The id that can be
+// used to identify the image from a command buffer.
+IPC_MESSAGE_ROUTED5(GpuCommandBufferMsg_CreateImage,
int32 /* id */,
gfx::GpuMemoryBufferHandle /* gpu_memory_buffer */,
- uint32 /* width */,
- uint32 /* height */,
+ gfx::Size /* size */,
+ gfx::GpuMemoryBuffer::Format /* format */,
uint32 /* internalformat */)
-// Unregister a previously registered gpu memory buffer.
-IPC_MESSAGE_ROUTED1(GpuCommandBufferMsg_UnregisterGpuMemoryBuffer,
+// Destroy a previously created image.
+IPC_MESSAGE_ROUTED1(GpuCommandBufferMsg_DestroyImage,
int32 /* id */)
// Attaches an external image stream to the client texture.

Powered by Google App Engine
This is Rietveld 408576698