content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h - Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor

Patch Set: address review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/child_process_host_impl.cc ('K') | « content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

index 643629ee8688f3861fc3b21bb2ccdaee2611c6c7..b0c287c5cad847b20fee811cafc309734fa44256 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

@@ -17,13 +17,13 @@ class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {

static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(

const gfx::GpuMemoryBufferHandle& handle,

const gfx::Size& size,

- unsigned internalformat,

+ Format format,

const DestructionCallback& callback);

- static bool IsFormatSupported(unsigned internalformat);

- static bool IsUsageSupported(unsigned usage);

- static bool IsConfigurationSupported(unsigned internalformat, unsigned usage);

- static int WindowFormat(unsigned internalformat);

+ static bool IsFormatSupported(Format format);

+ static bool IsUsageSupported(Usage usage);

+ static bool IsConfigurationSupported(Format format, Usage usage);

+ static int WindowFormat(Format format);

// Overridden from gfx::GpuMemoryBuffer:

virtual void* Map() override;

@@ -34,7 +34,7 @@ class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {

private:

GpuMemoryBufferImplSurfaceTexture(

const gfx::Size& size,

- unsigned internalformat,

+ Format format,

const DestructionCallback& callback,

const gfx::SurfaceTextureId& surface_texture_id,

ANativeWindow* native_window);