content/renderer/render_thread_impl.h - Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.h

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_thread_impl.h

diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h

index cb27dff813be817fc5007540c5fa757e2ba00f65..5712c010fba30d4716cb4cadf02e514920759b13 100644

--- a/content/renderer/render_thread_impl.h

+++ b/content/renderer/render_thread_impl.h

@@ -413,11 +413,6 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,

int32 surface_id,

const GPUCreateCommandBufferConfig& init_params,

int32 route_id) override;

- virtual scoped_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(

- size_t width,

- size_t height,

- unsigned internalformat,

- unsigned usage) override;

void Init();

@@ -559,11 +554,6 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,

scoped_ptr<WebRTCIdentityService> webrtc_identity_service_;

#endif

- // TODO(reveman): Allow AllocateGpuMemoryBuffer to be called from

- // multiple threads. Current allocation mechanism for IOSurface

- // backed GpuMemoryBuffers prevent this. crbug.com/325045

- base::ThreadChecker allocate_gpu_memory_buffer_thread_checker_;

scoped_ptr<MemoryObserver> memory_observer_;

scoped_refptr<base::SingleThreadTaskRunner>

« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »