content/common/gpu/client/command_buffer_proxy_impl.h - Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.h

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor

Patch Set: mac build fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/child_process_host_impl.cc ('K') | « content/common/child_process_messages.h ('k') | content/common/gpu/client/command_buffer_proxy_impl.cc » ('j') | ui/gfx/gpu_memory_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/command_buffer_proxy_impl.h

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.h b/content/common/gpu/client/command_buffer_proxy_impl.h

index 64474be06d3b517492b3626acbed47383d09c5b1..49f030f788baa52c44064e7633faab785cfb0a3c 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.h

+++ b/content/common/gpu/client/command_buffer_proxy_impl.h

@@ -98,12 +98,15 @@ class CommandBufferProxyImpl

// gpu::GpuControl implementation:

virtual gpu::Capabilities GetCapabilities() override;

- virtual gfx::GpuMemoryBuffer* CreateGpuMemoryBuffer(size_t width,

- size_t height,

- unsigned internalformat,

- unsigned usage,

- int32* id) override;

- virtual void DestroyGpuMemoryBuffer(int32 id) override;

+ virtual int32 CreateImage(ClientBuffer buffer,

+ size_t width,

+ size_t height,

+ unsigned internalformat) override;

+ virtual void DestroyImage(int32 id) override;

+ virtual int32 CreateGpuMemoryBufferImage(size_t width,

+ size_t height,

+ unsigned internalformat,

+ unsigned usage) override;

virtual uint32 InsertSyncPoint() override;

virtual uint32_t InsertFutureSyncPoint() override;

virtual void RetireSyncPoint(uint32_t sync_point) override;