content/browser/gpu/gpu_process_host.cc - Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_process_host.cc

Issue 634083002: gpu: Compositor management of GpuMemoryBuffer instances. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-pre-chromium-image-refactor

Patch Set: mac build fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('K') | « content/browser/gpu/gpu_process_host.h ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | content/common/child_process_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_process_host.cc

diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc

index 35019673a3cdb2b3b90ccdba66e1295826b81e99..cfd4773adbd4140e14efa4738754936836b0b8c6 100644

--- a/content/browser/gpu/gpu_process_host.cc

+++ b/content/browser/gpu/gpu_process_host.cc

@@ -650,15 +650,14 @@ void GpuProcessHost::CreateViewCommandBuffer(

void GpuProcessHost::CreateGpuMemoryBuffer(

const gfx::GpuMemoryBufferHandle& handle,

const gfx::Size& size,

- unsigned internalformat,

- unsigned usage,

+ gfx::GpuMemoryBuffer::Format format,

+ gfx::GpuMemoryBuffer::Usage usage,

const CreateGpuMemoryBufferCallback& callback) {

TRACE_EVENT0("gpu", "GpuProcessHost::CreateGpuMemoryBuffer");

DCHECK(CalledOnValidThread());

- if (Send(new GpuMsg_CreateGpuMemoryBuffer(

- handle, size, internalformat, usage))) {

+ if (Send(new GpuMsg_CreateGpuMemoryBuffer(handle, size, format, usage))) {

create_gpu_memory_buffer_requests_.push(callback);

} else {

callback.Run(gfx::GpuMemoryBufferHandle());