Delay copying effects from DS or ODS till end of creating ODS

Delay copying effects from DS or ODS till end of creating ODS

Also delay the removal of fixed function VA's until so we only have to do a single removal step

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9cf45bf119741b25c21337affc9746111fe6d38e

[egdaniel, 2014-10-07 20:07:02]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org, robertphillips@google.com

[egdaniel, 2014-10-07 20:07:03]

This change is here to help reduce some of the overhead/performance decreases we
observed in perf when creating an optDrawState.

[bsalomon, 2014-10-07 20:20:42]

https://codereview.chromium.org/634073002/diff/20001/src/gpu/GrOptDrawState.h
File src/gpu/GrOptDrawState.h (right):

https://codereview.chromium.org/634073002/diff/20001/src/gpu/GrOptDrawState.h...
src/gpu/GrOptDrawState.h:442: // Used when creating an OptDrawState from a
DrawState to keep track of which stages to copy
Do these really belong as members? Seems like they should be in a stack object
in Create that goes away when the ODS is finished construction.

[egdaniel, 2014-10-07 21:10:06]

https://codereview.chromium.org/634073002/diff/20001/src/gpu/GrOptDrawState.h
File src/gpu/GrOptDrawState.h (right):

https://codereview.chromium.org/634073002/diff/20001/src/gpu/GrOptDrawState.h...
src/gpu/GrOptDrawState.h:442: // Used when creating an OptDrawState from a
DrawState to keep track of which stages to copy
On 2014/10/07 20:20:42, bsalomon wrote:
> Do these really belong as members? Seems like they should be in a stack object
> in Create that goes away when the ODS is finished construction.

Done.

[bsalomon, 2014-10-07 21:15:43]

lgtm w/ nits

https://codereview.chromium.org/634073002/diff/60001/src/gpu/GrOptDrawState.cpp
File src/gpu/GrOptDrawState.cpp (right):

https://codereview.chromium.org/634073002/diff/60001/src/gpu/GrOptDrawState.c...
src/gpu/GrOptDrawState.cpp:79: // into color stages if everything is multipy
typo, missing 'l' in mulitply

https://codereview.chromium.org/634073002/diff/60001/src/gpu/GrOptDrawState.c...
src/gpu/GrOptDrawState.cpp:265: void
GrOptDrawState::computeEffectiveCoverageStages(const GrDrawState& ds, int*
firstCoverageStageIdx) {
overlength

[egdaniel, 2014-10-08 13:23:33]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-10-08 13:24:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634073002/80001

[egdaniel, 2014-10-08 13:30:32]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-10-08 13:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634073002/100001

[commit-bot: I haz the power, 2014-10-08 13:49:13]

Committed patchset #6 (id:100001) as 9cf45bf119741b25c21337affc9746111fe6d38e