Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: net/cert/x509_certificate_ios.cc

Issue 634033002: Check whether or not a certificate is self-signed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Once again, this is *Manos*... the *Hands*... of *Fate* Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate_ios.cc
diff --git a/net/cert/x509_certificate_ios.cc b/net/cert/x509_certificate_ios.cc
index b0908b77afae4b4397adbc8e4ca61f653e121406..275023d11178a931a1021a58d9ca037e7ff1e9f9 100644
--- a/net/cert/x509_certificate_ios.cc
+++ b/net/cert/x509_certificate_ios.cc
@@ -250,4 +250,10 @@ void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,
x509_util::GetPublicKeyInfo(nss_cert.cert_handle(), size_bits, type);
}
+// static
+bool X509Certificate::IsSelfSigned(OSCertHandle cert_handle) {
+ // TODO(palmer): Implement this.
Ryan Sleevi 2014/10/24 22:56:24 Are you planning on doing this? It's a blocker for
palmer 2014/10/24 23:32:46 Why is it a blocker? The only callers of this API
Ryan Sleevi 2014/10/24 23:46:53 1) You're gonna fail your unittest ;) 2) iOS is a
palmer 2014/10/27 21:20:27 Any hints as to what NSS API? The public docs seem
Ryan Sleevi 2014/10/27 21:22:17 The same one you're using in the _nss file? :)
+ return false;
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698