Issue 63403006: [Android] Guard perf_control creation in gtest test_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63403006: [Android] Guard perf_control creation in gtest test_runner. (Closed)

Created:
7 years, 1 month ago by frankf

Modified:
7 years, 1 month ago

Reviewers:
craigdh, Sami

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Guard perf_control creation in gtest test_runner. BUG=None TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235862

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/pylib/gtest/test_runner.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

frankf

On 2013/11/18 22:33:50, frankf wrote: @sami: This was causing issues for webkit tests: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/15008/steps/android_webview_unittests/logs/stdio

7 years, 1 month ago (2013-11-19 01:01:26 UTC) #2

frankf

Committed patchset #1 manually as r235862 (presubmit successful).

7 years, 1 month ago (2013-11-19 01:02:00 UTC) #3

Sami

7 years, 1 month ago (2013-11-19 11:39:20 UTC) #4

Message was sent while issue was closed.

Change itself lgtm, but looks like the root cause was an adb flake ('error:
protocol fault (no status)'). We might run into the same issue elsewhere.

Expand Messages | Collapse Messages