Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 634023004: Remove implicit conversions from scoped_refptr to T* in components/data_reduction_proxy (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/data_reduction_proxy Manual fixups for cases the automated tooling elected to skip. BUG=110610 TBR=bengr@chromium.org Committed: https://crrev.com/0beaf399dbe43b5d1de38b3c8145f8759e070d6b Cr-Commit-Position: refs/heads/master@{#298754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
6 years, 2 months ago (2014-10-07 22:15:14 UTC) #2
bolian
lgtm. added bengr for approval. Thanks for fxing this.
6 years, 2 months ago (2014-10-07 23:10:16 UTC) #4
dcheng
I haven't been able to get in touch with bengr. Given the trivial nature of ...
6 years, 2 months ago (2014-10-08 18:43:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634023004/1
6 years, 2 months ago (2014-10-08 18:45:55 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-08 18:45:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634023004/1
6 years, 2 months ago (2014-10-08 18:50:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 50e457d83f9e6fae0e2020c374186f3f63cbe1a4
6 years, 2 months ago (2014-10-08 19:09:49 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0beaf399dbe43b5d1de38b3c8145f8759e070d6b Cr-Commit-Position: refs/heads/master@{#298754}
6 years, 2 months ago (2014-10-08 19:12:41 UTC) #13
bengr
6 years, 2 months ago (2014-10-08 19:26:46 UTC) #14
Message was sent while issue was closed.
lgtm post facto

Powered by Google App Engine
This is Rietveld 408576698