Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 634013002: Move painting code from RenderFileUploadControl to FileUploadControlPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderFileUploadControl to FileUploadControlPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183388

Patch Set 1 #

Patch Set 2 : Merged. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -66 lines) Patch
M Source/core/core.gypi View 1 1 chunk +4 lines, -2 lines 0 comments Download
A Source/core/paint/FileUploadControlPainter.h View 1 chunk +26 lines, -0 lines 0 comments Download
A Source/core/paint/FileUploadControlPainter.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 3 chunks +4 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrishtr
6 years, 2 months ago (2014-10-07 18:16:21 UTC) #2
pdr.
So many fixmes in this code. I'm surprised it works at all! LGTM
6 years, 2 months ago (2014-10-07 18:20:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634013002/1
6 years, 2 months ago (2014-10-07 18:21:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30576)
6 years, 2 months ago (2014-10-08 01:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634013002/20001
6 years, 2 months ago (2014-10-08 04:51:02 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 06:35:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183388

Powered by Google App Engine
This is Rietveld 408576698