Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 633983002: Implemented retrieval of alerts history (Closed)

Created:
6 years, 2 months ago by Sergiy Byelozyorov
Modified:
6 years, 2 months ago
Reviewers:
Z_DONOTUSE, ojan
CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Refactored code and added tests #

Total comments: 2

Patch Set 3 : Renamed key to type #

Patch Set 4 : Bug fixes #

Patch Set 5 : Lowered MAX_LIMIT_PER_PAGE because it was generating too large response for AE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -13 lines) Patch
M Tools/GardeningServer/alerts.py View 1 2 3 4 5 chunks +57 lines, -10 lines 0 comments Download
M Tools/GardeningServer/alerts_test.py View 1 2 3 chunks +64 lines, -0 lines 0 comments Download
M Tools/GardeningServer/app.yaml View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Tools/GardeningServer/internal_alerts.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/GardeningServer/internal_alerts_test.py View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
Sergiy Byelozyorov
PTAL
6 years, 2 months ago (2014-10-07 18:48:42 UTC) #1
Z_DONOTUSE
lgtm https://codereview.chromium.org/633983002/diff/20001/Tools/GardeningServer/alerts.py File Tools/GardeningServer/alerts.py (right): https://codereview.chromium.org/633983002/diff/20001/Tools/GardeningServer/alerts.py#newcode29 Tools/GardeningServer/alerts.py:29: key = ndb.StringProperty() key implies uniqueness to me. ...
6 years, 2 months ago (2014-10-08 01:08:42 UTC) #3
Sergiy Byelozyorov
I've made some additional code changes after local testing. PTAL https://codereview.chromium.org/633983002/diff/20001/Tools/GardeningServer/alerts.py File Tools/GardeningServer/alerts.py (right): https://codereview.chromium.org/633983002/diff/20001/Tools/GardeningServer/alerts.py#newcode29 ...
6 years, 2 months ago (2014-10-08 12:50:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633983002/60001
6 years, 2 months ago (2014-10-08 12:54:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/16992)
6 years, 2 months ago (2014-10-08 13:01:21 UTC) #8
ojan
lgtm
6 years, 2 months ago (2014-10-09 06:11:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633983002/60001
6 years, 2 months ago (2014-10-09 06:11:51 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 183431
6 years, 2 months ago (2014-10-09 06:21:43 UTC) #12
Sergiy Byelozyorov
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/643613002/ by sergiyb@chromium.org. ...
6 years, 2 months ago (2014-10-09 12:47:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633983002/80001
6 years, 2 months ago (2014-10-10 12:08:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31177)
6 years, 2 months ago (2014-10-10 13:46:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633983002/80001
6 years, 2 months ago (2014-10-10 16:07:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31215)
6 years, 2 months ago (2014-10-10 18:01:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633983002/80001
6 years, 2 months ago (2014-10-13 01:08:27 UTC) #23
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 02:41:22 UTC) #24
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 183584

Powered by Google App Engine
This is Rietveld 408576698