Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 63393002: Mojo: Make the top-level mojo target build more. (Closed)

Created:
7 years, 1 month ago by viettrungluu
Modified:
7 years, 1 month ago
Reviewers:
sky, abarth-chromium
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Make the top-level mojo target build more. ("more" = "everything but the Android-only targets") R=sky@chromium.org, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233508

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M mojo/mojo.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
7 years, 1 month ago (2013-11-06 23:16:51 UTC) #1
sky
LGTM https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp File mojo/mojo.gyp (right): https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp#newcode18 mojo/mojo.gyp:18: 'mojo_system_unittests', Can you sort these?
7 years, 1 month ago (2013-11-06 23:29:41 UTC) #2
abarth-chromium
https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp File mojo/mojo.gyp (right): https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp#newcode26 mojo/mojo.gyp:26: 'native_viewport', Can we add the android ones in a ...
7 years, 1 month ago (2013-11-06 23:30:17 UTC) #3
viettrungluu
On 2013/11/06 23:30:17, abarth wrote: > https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp > File mojo/mojo.gyp (right): > > https://codereview.chromium.org/63393002/diff/1/mojo/mojo.gyp#newcode26 > ...
7 years, 1 month ago (2013-11-07 00:03:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/63393002/1
7 years, 1 month ago (2013-11-07 00:07:09 UTC) #5
abarth-chromium
Ok. I can take care of it.
7 years, 1 month ago (2013-11-07 00:08:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=221112
7 years, 1 month ago (2013-11-07 05:39:03 UTC) #7
viettrungluu
7 years, 1 month ago (2013-11-07 06:42:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r233508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698