Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 633923002: explicitly delete our c++ window on quit (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

explicitly delete our c++ window on quit BUG=skia: TBR= NOTRY=True Committed: https://skia.googlesource.com/skia/+/d3ce6b44e582c1a4c73a90b4314a387db8624ca2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/views/mac/SampleAppDelegate.mm View 1 chunk +1 line, -0 lines 0 comments Download
M src/views/mac/SkNSView.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 chunk +6 lines, -1 line 0 comments Download
M src/views/mac/SkSampleNSView.mm View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633923002/1
6 years, 2 months ago (2014-10-07 13:33:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633923002/1
6 years, 2 months ago (2014-10-07 13:41:57 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:42:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d3ce6b44e582c1a4c73a90b4314a387db8624ca2

Powered by Google App Engine
This is Rietveld 408576698