Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/bindings/scripts/scripts.gni

Issue 633913002: Update bindings gn files for binding modularization. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/bindings/modules/BUILD.gn ('K') | « Source/bindings/modules/modules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/scripts.gni
diff --git a/Source/bindings/scripts/scripts.gni b/Source/bindings/scripts/scripts.gni
index 41a80c6f3dd34cd3746b42912a68bfa6c84bf10e..7b5b3b96d2b093b24acb971a6f02f9a5a1a83df1 100644
--- a/Source/bindings/scripts/scripts.gni
+++ b/Source/bindings/scripts/scripts.gni
@@ -28,6 +28,7 @@ idl_compiler_files = get_path_info(_gypi.idl_compiler_files, "abspath")
# sources_generated = list of generated IDL files to pass as inputs
# component_dir = name if subdirectory (one word, no slashes) of component.
# output_file = pickle file to write
+# deps = dependencies
#
# FIXME: Note the static/generated split is for consistency with GYP. This
# split is not necessary in the GN build and could be combined into a single
@@ -61,11 +62,7 @@ template("compute_interfaces_info_individual") {
"--",
] + rebase_path(invoker.sources_generated, root_build_dir)
- deps = [
- # FIXME: should be {modules|core}_generated_idls
- # http://crbug.com/358074
- "//third_party/WebKit/Source/bindings:generated_idls",
- ]
+ deps = invoker.deps
}
}
« Source/bindings/modules/BUILD.gn ('K') | « Source/bindings/modules/modules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698