content/browser/service_worker/service_worker_database_unittest.cc - Issue 633873002: Service Worker: Respect the "clear on exit" content setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database_unittest.cc

Issue 633873002: Service Worker: Respect the "clear on exit" content setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@contentsettings

Patch Set: michaeln comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_database.cc ('k') | content/browser/service_worker/service_worker_registration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_database_unittest.cc

diff --git a/content/browser/service_worker/service_worker_database_unittest.cc b/content/browser/service_worker/service_worker_database_unittest.cc

index e8fd82cb200450fd54bb58b1779f4e8e168b37c6..ba477cd2e3beccf52d43d767e6aaa38b132d6048 100644

--- a/content/browser/service_worker/service_worker_database_unittest.cc

+++ b/content/browser/service_worker/service_worker_database_unittest.cc

@@ -995,9 +995,11 @@ TEST(ServiceWorkerDatabaseTest, DeleteAllDataForOrigin) {

database->WriteRegistration(

data3, resources3, &deleted_version_id, &newly_purgeable_resources));

+ std::set<GURL> origin_to_delete;

jochen (gone - plz use gerrit) 2014/10/09 11:42:05 super nit. origin*s*_to_delete

falken 2014/10/14 09:14:29 Done.

+ origin_to_delete.insert(origin1);

EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,

- database->DeleteAllDataForOrigin(origin1,

- &newly_purgeable_resources));

+ database->DeleteAllDataForOrigins(origin_to_delete,

+ &newly_purgeable_resources));

// |origin1| should be removed from the unique origin list.

std::set<GURL> unique_origins;