Issue 633863002: Invoke roll-dep with a git hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 633863002: Invoke roll-dep with a git hash. (Closed)

Created:
6 years, 2 months ago by szager1

Modified:
6 years, 2 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Project:
v8

Visibility:
Public.

Invoke roll-dep with a git hash. BUG=418923 R=machenbach@chromium.org

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/push-to-trunk/chromium_roll.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Yea, it would certainly fix it. I'll wait however for the answer to https://code.google.com/p/chromium/issues/detail?id=413555#c13 first.

6 years, 2 months ago (2014-10-07 08:38:58 UTC) #2

Michael Achenbach

6 years, 2 months ago (2014-10-14 09:02:05 UTC) #3

Closing this in favor of https://codereview.chromium.org/657483002/

I adapted the test expectations and removed all svn relics.