Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 633843002: Replacing the OVERRIDE with override and FINAL with final in content/browser/[dom_storage|gamepad|… (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/[dom_storage|gamepad|gpu|net] This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/5efc538c3a383638f36e027741f3f0964699300d Cr-Commit-Position: refs/heads/master@{#298386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -125 lines) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/dom_storage/local_storage_database_adapter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/dom_storage/session_storage_database_adapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/session_storage_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/session_storage_namespace_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_mac.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/gamepad_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gamepad/gamepad_test_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/raw_input_data_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/xbox_data_fetcher_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_memory_buffer_factory_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_surface_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/shader_disk_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/browser_online_state_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 03:41:20 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 04:15:31 UTC) #3
MRV
On 2014/10/07 04:15:31, Avi wrote: > Stampity stamp LGTM Thanks Mr. Avi for LGTM
6 years, 2 months ago (2014-10-07 04:22:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633843002/1
6 years, 2 months ago (2014-10-07 04:23:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as a067756df11015e2e8a87e6722a9567779f2d236
6 years, 2 months ago (2014-10-07 05:48:13 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:49:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5efc538c3a383638f36e027741f3f0964699300d
Cr-Commit-Position: refs/heads/master@{#298386}

Powered by Google App Engine
This is Rietveld 408576698