Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: components/crash/app/crash_reporter_client.h

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix content shell too Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/app/breakpad_linux.cc ('k') | components/crash/app/crash_reporter_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/app/crash_reporter_client.h
diff --git a/components/crash/app/crash_reporter_client.h b/components/crash/app/crash_reporter_client.h
index bb30d80f0813a9ed74527652d18036ea65af4982..4032bd199d790a54047b1e80156becb91e216870 100644
--- a/components/crash/app/crash_reporter_client.h
+++ b/components/crash/app/crash_reporter_client.h
@@ -98,9 +98,9 @@ class CrashReporterClient {
#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)
// Returns a textual description of the product type and version to include
- // in the crash report.
- virtual void GetProductNameAndVersion(std::string* product_name,
- std::string* version);
+ // in the crash report. Neither out parameter should be set to NULL.
+ virtual void GetProductNameAndVersion(const char** product_name,
+ const char** version);
virtual base::FilePath GetReporterLogFilename();
#endif
« no previous file with comments | « components/crash/app/breakpad_linux.cc ('k') | components/crash/app/crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698