Remove mediawiki stylesheet hack

Remove mediawiki stylesheet hack

According to https://bugs.webkit.org/show_bug.cgi?id=28350#c46,
we needed to wait until most of the top mediawiki installations
have to switched to version 1.5 or above. This time has come as
there is only one wiki in the top 200 with a version below 1.5.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161558

[ojan, 2013-11-07 19:27:18]

lgtm!


On Thu, Nov 7, 2013 at 8:55 AM, <jchaffraix@chromium.org> wrote:

> Reviewers: esprehn, ojan,
>
> Description:
> Remove mediawiki stylesheet hack
>
> According to https://bugs.webkit.org/show_bug.cgi?id=28350#c46,
> we needed to wait until most of the top mediawiki installations
> have to switched to version 1.5 or above. This time has come as
> there is only one wiki in the top 200 with a version below 1.5.
>
> Please review this at https://codereview.chromium.org/63383003/
>
> SVN Base: svn://svn.chromium.org/blink/trunk
>
> Affected files (+0, -9 lines):
>   M Source/core/css/StyleSheetContents.cpp
>
>
> Index: Source/core/css/StyleSheetContents.cpp
> diff --git a/Source/core/css/StyleSheetContents.cpp b/Source/core/css/
> StyleSheetContents.cpp
> index 1bcbbdafce75e21acb349c32c3845f61ba7782ff..
> 5e670ee52ab47d5f491bb5680f04f1cfe957039b 100644
> --- a/Source/core/css/StyleSheetContents.cpp
> +++ b/Source/core/css/StyleSheetContents.cpp
> @@ -293,15 +293,6 @@ void StyleSheetContents::parseAuthorStyleSheet(const
> CSSStyleSheetResource* cach
>              return;
>          }
>      }
> -    if (!quirksMode && m_parserContext.needsSiteSpecificQuirks) {
> -        // Work around <https://bugs.webkit.org/show_bug.cgi?id=28350>.
> -        DEFINE_STATIC_LOCAL(const String, mediaWikiKHTMLFixesStyleSheet,
> ("/* KHTML fix stylesheet */\n/* work around the horizontal scrollbars
> */\n#column-content { margin-left: 0; }\n\n"));
> -        // There are two variants of KHTMLFixes.css. One is equal to
> mediaWikiKHTMLFixesStyleSheet,
> -        // while the other lacks the second trailing newline.
> -        if (baseURL().string().endsWith("/KHTMLFixes.css") &&
> !sheetText.isNull() && mediaWikiKHTMLFixesStyleSheet.startsWith(sheetText)
> -            && sheetText.length() >= mediaWikiKHTMLFixesStyleSheet.length()
> - 1)
> -            clearRules();
> -    }
>  }
>
>  bool StyleSheetContents::parseString(const String& sheetText)
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-07 19:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/63383003/1

[commit-bot: I haz the power, 2013-11-07 22:13:09]

Change committed as 161558