Don't use mock PagePopup if possible, part 2

Don't use mock PagePopup if possible, part 2

Update some tests in fast/forms/suggestion-picker/ so that they use
openPicker() instead of openPickerWithMock().

BUG=409503
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183720

[tkent, 2014-10-07 07:37:27]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2014-10-07 07:37:28]

Keishi, would you review this please?

[keishi, 2014-10-07 09:05:33]

On 2014/10/07 07:37:28, tkent wrote:
> Keishi, would you review this please?

Key operation tests seem to be failing.

[tkent, 2014-10-08 01:09:15]

On 2014/10/07 09:05:33, keishi wrote:
> On 2014/10/07 07:37:28, tkent wrote:
> > Keishi, would you review this please?
> 
> Key operation tests seem to be failing.

I forgot to update -expected.txt for them.  I worked on OSX, and these tests
have platform-specific -expected.txt.
Will update the patch.

[keishi, 2014-10-08 02:13:16]

lgtm

[tkent, 2014-10-08 02:33:36]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-10-08 02:34:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633823003/20001

[commit-bot: I haz the power, 2014-10-08 04:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 04:53:12]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

[tkent, 2014-10-08 05:59:26]

On 2014/10/08 04:53:12, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_dbg on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)

This CL exposed another issue.  I'm filing a bug.

[tkent, 2014-10-15 02:16:42]

Patchset #3 (id:40001) has been deleted

[tkent, 2014-10-15 03:20:20]

On 2014/10/08 05:59:26, tkent wrote:
> On 2014/10/08 04:53:12, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_blink_dbg on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
> 
> This CL exposed another issue.  I'm filing a bug.

The issue was fixed.  I rebased this CL, and landing it.

[tkent, 2014-10-15 03:20:25]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-10-15 03:21:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633823003/60001

[commit-bot: I haz the power, 2014-10-15 03:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 03:22:06]

Failed to apply patch for
LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
  Hunk #1 FAILED at 87.
  Hunk #2 FAILED at 139.
  2 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html.rej

Patch:      
LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
Index:
LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
diff --git
a/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
b/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
index
774e127469a4950b0aec6296f8d175c6ead81bc1..5229b6b57013044180f87d3ee777a60efd8ac2e1
100644
---
a/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
+++
b/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html
@@ -87,7 +87,7 @@ description("Tests that key bindings work as expected.");
 debug('Check that page popup doesn\'t exist at first.');
 shouldBeNull('document.getElementById("mock-page-popup")');
 
-openPickerWithMock(document.getElementById('date'), test1);
+openPicker(document.getElementById('date'), test1);
 
 var expectingDidHideEvent = false;
 
@@ -139,7 +139,7 @@ function test1AfterClosing() {
     shouldBeEqualToString('document.getElementById("date").value',
'2012-03-08');
 
     debug('Reopen popup.');
-    openPickerWithMock(document.getElementById('date'), test2);
+    openPicker(document.getElementById('date'), test2);
 }
 
 function test2() {

[tkent, 2014-10-15 03:30:52]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-10-15 03:31:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633823003/80001

[commit-bot: I haz the power, 2014-10-15 05:39:45]

Committed patchset #4 (id:80001) as 183720