pkg/analyzer/lib/src/generated/resolver.dart - Issue 633803002: Check parameter types when evaluating constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 633803002: Check parameter types when evaluating constants. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« pkg/analyzer/lib/src/generated/constant.dart ('K') | « pkg/analyzer/lib/src/generated/error.dart ('k') | pkg/analyzer/test/generated/all_the_rest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 32a0138c49ecc05510821561e80dbe41e800c147..1c83818faa6124ebbea48001899378e00d892ee2 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -1617,7 +1617,13 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {

void _reportErrors(List<AnalysisError> errors, ErrorCode errorCode) {

for (AnalysisError data in errors) {

ErrorCode dataErrorCode = data.errorCode;

- if (identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION) || identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_THROWS_IDBZE) || identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL_NUM_STRING) || identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL) || identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_INT) || identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_NUM)) {

+ if (identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION) ||

+ identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_THROWS_IDBZE) ||

+ identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL_NUM_STRING) ||

+ identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL) ||

+ identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_INT) ||

+ identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_NUM) ||

+ identical(dataErrorCode, CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH)) {

_errorReporter.reportError(data);

} else if (errorCode != null) {

_errorReporter.reportError(new AnalysisError.con2(data.source, data.offset, data.length, errorCode, []));

« pkg/analyzer/lib/src/generated/constant.dart ('K') | « pkg/analyzer/lib/src/generated/error.dart ('k') | pkg/analyzer/test/generated/all_the_rest.dart » ('j') | no next file with comments »