Check parameter types when evaluating constants.

pkg/analyzer/lib/src/error_formatter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library error_formatter;
 
 import 'generated/engine.dart';
 import 'generated/error.dart';
 import 'generated/source_io.dart';
 import '../options.dart';
+import 'package:analyzer/src/analyzer_impl.dart';
 
 /// Returns `true` if [AnalysisError] should be printed.
 typedef bool _ErrorFilter(AnalysisError error);
 
 /// Allows any [AnalysisError].
 bool _anyError(AnalysisError error) => true;
 
 /**
  * Helper for formatting [AnalysisError]s.
  * The two format options are a user consumable format and a machine consumable format.
@@ skipping 12 matching lines @@
       for (AnalysisError error in errorInfo.errors) {
         if (errorFilter(error)) {
           errors.add(error);
           errorToLine[error] = errorInfo.lineInfo;
         }
       }
     }
     // sort errors
     errors.sort((AnalysisError error1, AnalysisError error2) {
       // severity
-      int compare = error2.errorCode.errorSeverity.compareTo(error1.errorCode.errorSeverity);
+      ErrorSeverity severity1 = AnalyzerImpl.computeSeverity(
+          error1, options.enableTypeChecks);
+      ErrorSeverity severity2 = AnalyzerImpl.computeSeverity(
+          error2, options.enableTypeChecks);
+      int compare = severity2.compareTo(severity1);
       if (compare != 0) {
         return compare;
       }
       // path
       compare = Comparable.compare(error1.source.fullName.toLowerCase(), error2.source.fullName.toLowerCase());
       if (compare != 0) {
         return compare;
       }
       // offset
       return error1.offset - error2.offset;
     });
     // format errors
     int errorCount = 0;
     int warnCount = 0;
     int hintCount = 0;
     for (AnalysisError error in errors) {
-      var severity = error.errorCode.errorSeverity;
+      ErrorSeverity severity = AnalyzerImpl.computeSeverity(
+          error, options.enableTypeChecks);
       if (severity == ErrorSeverity.ERROR) {
         errorCount++;
       } else if (severity == ErrorSeverity.WARNING) {
         if (options.warningsAreFatal) {
           errorCount++;
         } else {
           if (error.errorCode.type == ErrorType.HINT) {
             hintCount++;
           } else {
             warnCount++;
@@ skipping 41 matching lines @@
       } else {
         out.writeln("No issues found");
       }
     }
   }
 
   void formatError(Map<AnalysisError, LineInfo> errorToLine, AnalysisError error) {
     Source source = error.source;
     LineInfo_Location location = errorToLine[error].getLocation(error.offset);
     int length = error.length;
-    var severity = error.errorCode.errorSeverity;
+    ErrorSeverity severity = AnalyzerImpl.computeSeverity(
+        error, options.enableTypeChecks);
     if (options.machineFormat) {
       if (severity == ErrorSeverity.WARNING && options.warningsAreFatal) {
         severity = ErrorSeverity.ERROR;
       }
       out.write(severity);
       out.write('|');
       out.write(error.errorCode.type);
       out.write('|');
       out.write(error.errorCode);
       out.write('|');
       out.write(escapePipe(source.fullName));
       out.write('|');
       out.write(location.lineNumber);
       out.write('|');
       out.write(location.columnNumber);
       out.write('|');
       out.write(length);
       out.write('|');
       out.write(escapePipe(error.message));
     } else {
-      String errorType = error.errorCode.errorSeverity.displayName;
+      String errorType = severity.displayName;
       if (error.errorCode.type == ErrorType.HINT) {
         errorType = error.errorCode.type.displayName;
       }
       // [warning] 'foo' is not a... (/Users/.../tmp/foo.dart, line 1, col 2)
       out.write('[$errorType] ${error.message} ');
       out.write('(${source.fullName}');
       out.write(', line ${location.lineNumber}, col ${location.columnNumber})');
     }
     out.writeln();
   }
@@ skipping 10 matching lines @@
   }
 
   static String pluralize(String word, int count) {
     if (count == 1) {
       return word;
     } else {
       return word + "s";
     }
   }
 }