Check parameter types when evaluating constants.

pkg/analyzer/lib/src/analyzer_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_impl;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'generated/constant.dart';
@@ skipping 16 matching lines @@
 
 /**
  * The maximum number of sources for which AST structures should be kept in the cache.
  */
 const int _MAX_CACHE_SIZE = 512;
 
 DirectoryBasedDartSdk sdk;
 
 /// Analyzes single library [File].
 class AnalyzerImpl {
+  /**
+   * Compute the severity of the error; however, if
+   * [escalateCheckedModeCompileTimeErrors] is true, then escalate it to
+   * [ErrorSeverity.ERROR].
+   */
+  static ErrorSeverity computeSeverity(
+      AnalysisError error, bool escalateCheckedModeCompileTimeErrors) {
+    if (escalateCheckedModeCompileTimeErrors
+        && error.errorCode.type == ErrorType.CHECKED_MODE_COMPILE_TIME_ERROR) {
+      return ErrorSeverity.ERROR;
+    }
+    return error.errorCode.errorSeverity;
+  }
+
   final String sourcePath;
   final CommandLineOptions options;
   final int startTime;
 
   ContentCache contentCache = new ContentCache();
   SourceFactory sourceFactory;
   AnalysisContext context;
   Source librarySource;
 
   /// All [Source]s references by the analyzed library.
@@ skipping 108 matching lines @@
       ErrorSeverity status = maxErrorSeverity;
       if (status == ErrorSeverity.WARNING && options.warningsAreFatal) {
         status = ErrorSeverity.ERROR;
       }
       exitCode = status.ordinal;
     }).catchError((ex, st) {
       AnalysisEngine.instance.logger.logError("${ex}\n${st}");
     });
   }
 
-  bool _excludeTodo(AnalysisError error) =>
-      error.errorCode.type != ErrorType.TODO;
+  bool _isDesiredError(AnalysisError error) {
+    if (error.errorCode.type == ErrorType.TODO) {
+      return false;
+    }
+    if (computeSeverity(error, options.enableTypeChecks) == ErrorSeverity.INFO
+        && options.disableHints) {
+      return false;
+    }
+    return true;
+  }
 
   _printErrorsAndPerf() {
     // The following is a hack. We currently print out to stderr to ensure that
     // when in batch mode we print to stderr, this is because the prints from
     // batch are made to stderr. The reason that options.shouldBatch isn't used
     // is because when the argument flags are constructed in BatchRunner and
     // passed in from batch mode which removes the batch flag to prevent the
     // "cannot have the batch flag and source file" error message.
     IOSink sink = options.machineFormat ? stderr : stdout;
 
     // print errors
-    ErrorFormatter formatter = new ErrorFormatter(sink, options, _excludeTodo);
+    ErrorFormatter formatter = new ErrorFormatter(sink, options, _isDesiredError);
     formatter.formatErrors(errorInfos);
 
     // print performance numbers
     if (options.perf || options.warmPerf) {
       int totalTime = JavaSystem.currentTimeMillis() - startTime;
       int ioTime = PerformanceStatistics.io.result;
       int scanTime = PerformanceStatistics.scan.result;
       int parseTime = PerformanceStatistics.parse.result;
       int resolveTime = PerformanceStatistics.resolve.result;
       int errorsTime = PerformanceStatistics.errors.result;
@@ skipping 34 matching lines @@
         - (ioTime + scanTime + parseTime + resolveTime + errorsTime + hintsTime
         + angularTime)}");
     stdout.writeln("total-cold:$totalTime");
   }
 
   /// Returns the maximal [ErrorSeverity] of the recorded errors.
   ErrorSeverity get maxErrorSeverity {
     var status = ErrorSeverity.NONE;
     for (AnalysisErrorInfo errorInfo in errorInfos) {
       for (AnalysisError error in errorInfo.errors) {
-        var severity = error.errorCode.errorSeverity;
+        if (!_isDesiredError(error)) {
+          continue;
+        }
+        var severity = computeSeverity(error, options.enableTypeChecks);
         status = status.max(severity);
       }
     }
     return status;
   }
 
   void prepareAnalysisContext(JavaFile sourceFile, Source source) {
     List<UriResolver> resolvers = [
         new DartUriResolver(sdk),
         new FileUriResolver()];
@@ skipping 158 matching lines @@
     }
   }
 
   @override
   void logInformation2(String message, Exception exception) {
     if (log) {
       stdout.writeln(message);
     }
   }
 }