[chromedriver] Add a WebView shell app for testing.

[chromedriver] Add a WebView shell app for testing.

BUG=None
R=craigdh@chromium.org
TBR=navabi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234255

[craigdh, 2013-11-07 23:26:59]

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:160:
'org.chromium.chromedriver_webview_shell'),
add this to constants.PACKAGE_INFO

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:160:
'org.chromium.chromedriver_webview_shell'),
Also, is the bot on KitKat yet?

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
File chrome/test/chromedriver/chrome/device_manager.cc (right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
chrome/test/chromedriver/chrome/device_manager.cc:62: package.find("webview") ==
std::string::npos) {
this is starting to feel a bit hacky

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
File chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
(right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml:9:
package="org.chromium.chromedriver_webview_shell" android:versionCode="1"
There's nothing about this implementation that is specific to chromedriver, how
about "DevToolsWebviewShell" or similar?

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
File
chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java
(right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java:37:
activity.setProgress(progress * 100);
indent

[frankf, 2013-11-08 21:20:54]

ptal

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:160:
'org.chromium.chromedriver_webview_shell'),
On 2013/11/07 23:26:59, craigdh wrote:
> add this to constants.PACKAGE_INFO

Done.

https://codereview.chromium.org/63373003/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:160:
'org.chromium.chromedriver_webview_shell'),
On 2013/11/07 23:26:59, craigdh wrote:
> Also, is the bot on KitKat yet?

No, I'll upgrade it before landing

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
File chrome/test/chromedriver/chrome/device_manager.cc (right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
chrome/test/chromedriver/chrome/device_manager.cc:62: package.find("webview") ==
std::string::npos) {
On 2013/11/07 23:26:59, craigdh wrote:
> this is starting to feel a bit hacky

Any suggestions? We could list all chrome 4 chrome packages, but what's the
downside of current implementation?

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
File chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
(right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml:9:
package="org.chromium.chromedriver_webview_shell" android:versionCode="1"
I thought about it, this could also be used by Telemetry. But I think this is
small-enough that we want
our own version to freely modify without worrying about how it's used elsewhere.

On 2013/11/07 23:26:59, craigdh wrote:
> There's nothing about this implementation that is specific to chromedriver,
how
> about "DevToolsWebviewShell" or similar?

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
File
chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java
(right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/test...
chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java:37:
activity.setProgress(progress * 100);
On 2013/11/07 23:26:59, craigdh wrote:
> indent

Done.

[craigdh, 2013-11-11 17:55:43]

lgtm. Make sure to flash the device before landing.

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
File chrome/test/chromedriver/chrome/device_manager.cc (right):

https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
chrome/test/chromedriver/chrome/device_manager.cc:62: package.find("webview") ==
std::string::npos) {
On 2013/11/08 21:20:55, frankf wrote:
> On 2013/11/07 23:26:59, craigdh wrote:
> > this is starting to feel a bit hacky
> 
> Any suggestions? We could list all chrome 4 chrome packages, but what's the
> downside of current implementation?

No, I didn't have anything better in mind. Just a general complaint :)

[frankf, 2013-11-11 18:41:55]

On 2013/11/11 17:55:43, craigdh wrote:
> lgtm. Make sure to flash the device before landing.
> 
>
https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
> File chrome/test/chromedriver/chrome/device_manager.cc (right):
> 
>
https://codereview.chromium.org/63373003/diff/1/chrome/test/chromedriver/chro...
> chrome/test/chromedriver/chrome/device_manager.cc:62: package.find("webview")
==
> std::string::npos) {
> On 2013/11/08 21:20:55, frankf wrote:
> > On 2013/11/07 23:26:59, craigdh wrote:
> > > this is starting to feel a bit hacky
> > 
> > Any suggestions? We could list all chrome 4 chrome packages, but what's the
> > downside of current implementation?
> 
> No, I didn't have anything better in mind. Just a general complaint :)

I'm gonna hold of running the tests since we don't have a device yet.

[commit-bot: I haz the power, 2013-11-11 18:42:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/63373003/180001

[commit-bot: I haz the power, 2013-11-11 19:03:11]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[frankf, 2013-11-11 19:21:08]

Committed patchset #3 manually as r234255 (presubmit successful).