Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 633703004: Android Chromoting: Don't include API key with Directory request (Closed)

Created:
6 years, 2 months ago by Lambros
Modified:
6 years, 2 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Chromoting: Don't include API key with Directory request This is needed to help transition the client to a device-based OAuth flow. BUG=417799 Committed: https://crrev.com/6a7b821b51ec60cb0cfe9ba926526ec4671b7937 Cr-Commit-Position: refs/heads/master@{#299225}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove client_id/client_secret from request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/HostListLoader.java View 1 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lambros
6 years, 2 months ago (2014-10-06 23:00:40 UTC) #2
Lambros
https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java File remoting/android/java/src/org/chromium/chromoting/HostListLoader.java (right): https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java#newcode90 remoting/android/java/src/org/chromium/chromoting/HostListLoader.java:90: link.addRequestProperty("client_id", JniInterface.nativeGetClientId()); Maybe we should remove these lines as ...
6 years, 2 months ago (2014-10-06 23:03:21 UTC) #3
rmsousa
lgtm https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java File remoting/android/java/src/org/chromium/chromoting/HostListLoader.java (right): https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java#newcode90 remoting/android/java/src/org/chromium/chromoting/HostListLoader.java:90: link.addRequestProperty("client_id", JniInterface.nativeGetClientId()); On 2014/10/06 23:03:21, Lambros wrote: > ...
6 years, 2 months ago (2014-10-06 23:13:25 UTC) #4
Lambros
https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java File remoting/android/java/src/org/chromium/chromoting/HostListLoader.java (right): https://codereview.chromium.org/633703004/diff/1/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java#newcode90 remoting/android/java/src/org/chromium/chromoting/HostListLoader.java:90: link.addRequestProperty("client_id", JniInterface.nativeGetClientId()); On 2014/10/06 23:13:25, rmsousa wrote: > On ...
6 years, 2 months ago (2014-10-07 00:11:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633703004/20001
6 years, 2 months ago (2014-10-11 00:54:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-11 01:31:25 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 01:32:07 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6a7b821b51ec60cb0cfe9ba926526ec4671b7937
Cr-Commit-Position: refs/heads/master@{#299225}

Powered by Google App Engine
This is Rietveld 408576698