Enable float source size

Enable float source size

The source-size in the sizes parsing algorithm was wrongfully returned as unsigned. This CL fixes that to enable floats there.

BUG=418905
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183401

[Yoav Weiss, 2014-10-06 22:33:58]

yoav@yoav.ws changed reviewers:
+ esprehn@chromium.org, mkwst@chromium.org

[Yoav Weiss, 2014-10-07 10:09:52]

yoav@yoav.ws changed reviewers:
+ acutter@chromium.org, timloh@google.com
- esprehn@chromium.org, mkwst@chromium.org

[Timothy Loh, 2014-10-08 05:02:42]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org
- acutter@chromium.org, timloh@google.com

[Timothy Loh, 2014-10-08 05:02:42]

lgtm

[Yoav Weiss, 2014-10-08 05:12:44]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-10-08 05:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633643003/1

[commit-bot: I haz the power, 2014-10-08 05:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 05:14:03]

Failed to apply patch for Source/core/css/parser/SizesAttributeParser.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/parser/SizesAttributeParser.cpp
  Hunk #1 FAILED at 22.
  Hunk #3 succeeded at 137 (offset 1 line).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/css/parser/SizesAttributeParser.cpp.rej

Patch:       Source/core/css/parser/SizesAttributeParser.cpp
Index: Source/core/css/parser/SizesAttributeParser.cpp
diff --git a/Source/core/css/parser/SizesAttributeParser.cpp
b/Source/core/css/parser/SizesAttributeParser.cpp
index
1ca67fe16781f0e7cf6bd21415f58e7e597fc2f4..e792a6a84470b2408f4ff23edb49af4b08ddf0d1
100644
--- a/Source/core/css/parser/SizesAttributeParser.cpp
+++ b/Source/core/css/parser/SizesAttributeParser.cpp
@@ -22,25 +22,25 @@
SizesAttributeParser::SizesAttributeParser(PassRefPtr<MediaValues> mediaValues,
     m_isValid = parse(m_tokens);
 }
 
-unsigned SizesAttributeParser::length()
+float SizesAttributeParser::length()
 {
     if (m_isValid)
         return effectiveSize();
     return effectiveSizeDefaultValue();
 }
 
-bool SizesAttributeParser::calculateLengthInPixels(MediaQueryTokenIterator
startToken, MediaQueryTokenIterator endToken, unsigned& result)
+bool SizesAttributeParser::calculateLengthInPixels(MediaQueryTokenIterator
startToken, MediaQueryTokenIterator endToken, float& result)
 {
     if (startToken == endToken)
         return false;
     MediaQueryTokenType type = startToken->type();
     if (type == DimensionToken) {
-        int length;
+        double length;
         if (!CSSPrimitiveValue::isLength(startToken->unitType()))
             return false;
         m_viewportDependant =
CSSPrimitiveValue::isViewportPercentageLength(startToken->unitType());
         if ((m_mediaValues->computeLength(startToken->numericValue(),
startToken->unitType(), length)) && (length > 0)) {
-            result = (unsigned)length;
+            result = clampTo<float>(length);
             return true;
         }
     } else if (type == FunctionToken) {
@@ -104,7 +104,7 @@ bool
SizesAttributeParser::parseMediaConditionAndLength(MediaQueryTokenIterator
     lengthTokenEnd = endToken;
     reverseSkipUntilComponentStart(endToken, startToken);
     lengthTokenStart = endToken;
-    unsigned length;
+    float length;
     if (!calculateLengthInPixels(lengthTokenStart, lengthTokenEnd, length))
         return false;
     RefPtrWillBeRawPtr<MediaQuerySet> mediaCondition =
MediaQueryParser::parseMediaCondition(startToken, endToken);
@@ -136,7 +136,7 @@ bool SizesAttributeParser::parse(Vector<MediaQueryToken>&
tokens)
     return parseMediaConditionAndLength(startToken, --endToken);
 }
 
-unsigned SizesAttributeParser::effectiveSize()
+float SizesAttributeParser::effectiveSize()
 {
     if (m_lengthWasSet)
         return m_length;

[Yoav Weiss, 2014-10-08 07:21:43]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-10-08 07:23:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633643003/20001

[commit-bot: I haz the power, 2014-10-08 07:39:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 07:39:49]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/26240)

[Yoav Weiss, 2014-10-08 09:12:39]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-10-08 09:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633643003/40001

[commit-bot: I haz the power, 2014-10-08 09:35:43]

Committed patchset #3 (id:40001) as 183401

[Yoav Weiss, 2014-10-08 09:41:12]

Patchset #4 (id:60001) has been deleted