Handle transient children as a part of transient parent

Handle transient children as a part of transient parent

Exclude transient children from window list.

Introduced TransientGroupSetter to set the window property to all transient children.

This CL depends on https://codereview.chromium.org/628413002/.

BUG=410499
TEST=Updated WindowListProviderImplTest.
Manual tests for animations: go to chrome://extensions, enable dev mode, and open file dialog. Go to overview mode, scroll, delete, select activity with file dialog.

Committed: https://crrev.com/bb11c71d45fea38bab72ca28a6c44b19c7d9f564
Cr-Commit-Position: refs/heads/master@{#298890}

[oshima, 2014-10-07 07:30:39]

Patchset #2 (id:20001) has been deleted

[oshima, 2014-10-07 07:30:46]

Patchset #2 (id:40001) has been deleted

[oshima, 2014-10-07 07:31:12]

Patchset #1 (id:1) has been deleted

[oshima, 2014-10-07 07:33:09]

Patchset #1 (id:60001) has been deleted

[oshima, 2014-10-07 09:04:06]

Patchset #1 (id:80001) has been deleted

[oshima, 2014-10-07 09:04:11]

Patchset #1 (id:100001) has been deleted

[oshima, 2014-10-07 18:18:38]

Patchset #1 (id:90008) has been deleted

[oshima, 2014-10-07 18:18:42]

Patchset #1 (id:130001) has been deleted

[oshima, 2014-10-07 18:18:46]

Patchset #1 (id:150001) has been deleted

[oshima, 2014-10-07 18:18:52]

Patchset #1 (id:170001) has been deleted

[oshima, 2014-10-07 18:22:39]

Patchset #1 (id:190001) has been deleted

[oshima, 2014-10-07 18:28:17]

oshima@chromium.org changed reviewers:
+ skuhne@chromium.org

[oshima, 2014-10-07 19:15:03]

Patchset #1 (id:210001) has been deleted

[oshima, 2014-10-07 19:15:09]

Patchset #1 (id:220001) has been deleted

[oshima, 2014-10-07 19:15:15]

Patchset #1 (id:240001) has been deleted

[oshima, 2014-10-07 19:15:20]

Patchset #1 (id:260001) has been deleted

[Mr4D (OOO till 08-26), 2014-10-08 03:44:25]

A few comments. I'll have another look tomorrow

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
File athena/wm/window_list_provider_impl.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
athena/wm/window_list_provider_impl.cc:33: for (auto* window : window_list_)
Don't you want to set the property here as well? Maybe even call OnWindowAdded?

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
File athena/wm/window_list_provider_impl.h (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
athena/wm/window_list_provider_impl.h:9: #include "base/gtest_prod_util.h"
Why do you need this?

[Mr4D (OOO till 08-26), 2014-10-08 15:32:29]

Please look at my comments first, then lgtm

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
File athena/wm/window_list_provider_impl_unittest.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
athena/wm/window_list_provider_impl_unittest.cc:300: // That transient windows
are handled property.
Test that ..
?

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_overvi...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_overvi...
athena/wm/window_overview_mode.cc:108: : window_(window) {
This would fit into one line.

[Mr4D (OOO till 08-26), 2014-10-08 17:15:36]

one more comment

https://codereview.chromium.org/633623002/diff/280001/athena/content/content_...
File athena/content/content_activity_factory.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/content/content_...
athena/content/content_activity_factory.cc:26:
activity->GetWindow()->SetName("WebActivity");
You might consider putting this into a separate CL since it does not have
anything to do with the rest of the patch.

[oshima, 2014-10-08 19:05:30]

https://codereview.chromium.org/633623002/diff/280001/athena/content/content_...
File athena/content/content_activity_factory.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/content/content_...
athena/content/content_activity_factory.cc:26:
activity->GetWindow()->SetName("WebActivity");
On 2014/10/08 17:15:36, Mr4D wrote:
> You might consider putting this into a separate CL since it does not have
> anything to do with the rest of the patch.

sure

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
File athena/wm/window_list_provider_impl_unittest.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_list_p...
athena/wm/window_list_provider_impl_unittest.cc:300: // That transient windows
are handled property.
On 2014/10/08 15:32:29, Mr4D wrote:
> Test that ..
> ?

Done.

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_overvi...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/633623002/diff/280001/athena/wm/window_overvi...
athena/wm/window_overview_mode.cc:108: : window_(window) {
On 2014/10/08 15:32:29, Mr4D wrote:
> This would fit into one line.

Done.

[oshima, 2014-10-08 19:08:12]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-08 19:09:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633623002/300001

[commit-bot: I haz the power, 2014-10-09 01:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 01:15:08]

Exceeded time limit waiting for builds to trigger.

[oshima, 2014-10-09 15:50:56]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-09 15:51:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633623002/300001

[commit-bot: I haz the power, 2014-10-09 16:15:37]

Committed patchset #2 (id:300001) as 8c8f6b0728014c75ee19382deb0293ddd409b26f

[commit-bot: I haz the power, 2014-10-09 16:16:39]

Patchset 2 (id:??) landed as
https://crrev.com/bb11c71d45fea38bab72ca28a6c44b19c7d9f564
Cr-Commit-Position: refs/heads/master@{#298890}