Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 633603002: [NaCl SDK] Update Visual Studio Addin docs to reflect VS2012 support. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
jpmedley, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update Visual Studio Addin docs to reflect VS2012 support. NOTRY=true Committed: https://crrev.com/29257f9f0f22bcf5af186ee0723d49b32c5586c4 Cr-Commit-Position: refs/heads/master@{#298291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html View 3 chunks +7 lines, -6 lines 0 comments Download
M native_client_sdk/doc_generated/pepper_stable/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/vs-addin.rst View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam Clegg
6 years, 2 months ago (2014-10-06 18:09:11 UTC) #2
binji
+jmedley lgtm
6 years, 2 months ago (2014-10-06 18:59:20 UTC) #4
jpmedley
lgtm
6 years, 2 months ago (2014-10-06 19:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633603002/1
6 years, 2 months ago (2014-10-06 19:17:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 09472f86b5025b86360c2e5aee074bf3bf746251
6 years, 2 months ago (2014-10-06 19:20:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 19:57:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29257f9f0f22bcf5af186ee0723d49b32c5586c4
Cr-Commit-Position: refs/heads/master@{#298291}

Powered by Google App Engine
This is Rietveld 408576698