Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 633553003: emitIAS for push -- simplify push since it's not used for args passing anymore (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

emitIAS for push -- simplify push since it's not used for args passing anymore Since push isn't used for args passing anymore, the cases of handling push for vectors and floats/doubles isn't needed anymore. Passing vectors requires a bit more care of alignment, so that was changed. I can imagine push needing to handle addresses later (at least on x86-64 to push the lower 32-bits of return address), but for now, this means only handling GPRs. The XMM registers are not callee saved. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0b9eee5221afe4c074e51313cb272556bb1415bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -57 lines) Patch
M src/IceInstX8632.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/IceInstX8632.cpp View 2 chunks +20 lines, -32 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/assembler_ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler_ia32.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-10-06 14:56:57 UTC) #2
Jim Stichnoth
LGTM. I envision at least one future use of push/pop: 1. Do normal lowering and ...
6 years, 2 months ago (2014-10-06 15:09:21 UTC) #3
jvoung (off chromium)
6 years, 2 months ago (2014-10-07 18:20:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0b9eee5221afe4c074e51313cb272556bb1415bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698