Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 633553002: Replace OVERRIDE and FINAL with override and final in content/browser/browser_plugin/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/browser/browser_plugin/[a-s]* BUG=417463 Committed: https://crrev.com/766d13aaa84813058152abb508c19561a0fc1f8c Cr-Commit-Position: refs/heads/master@{#298259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Ratn (left samsung)
PTAL
6 years, 2 months ago (2014-10-06 14:32:18 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-10-06 14:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633553002/1
6 years, 2 months ago (2014-10-06 15:38:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6aaf803f6331569934ffc1c238026e69853aed6d
6 years, 2 months ago (2014-10-06 17:19:18 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:20:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/766d13aaa84813058152abb508c19561a0fc1f8c
Cr-Commit-Position: refs/heads/master@{#298259}

Powered by Google App Engine
This is Rietveld 408576698