Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 633463003: Replacing the OVERRIDE with override in /src/athena (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in /src/athena This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/46c005518fa8fcc857dedf56107a9ebdd33a781d Cr-Commit-Position: refs/heads/master@{#298650}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M athena/test/base/activity_lifetime_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/chrome/athena_app_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 09:47:55 UTC) #2
anujsharma
On 2014/10/06 09:47:55, anujsharma wrote: > PTAL @SKY, Could you please give one thumbs up ...
6 years, 2 months ago (2014-10-07 02:39:58 UTC) #3
sky
LGTM - but update your description. There is no final here.
6 years, 2 months ago (2014-10-07 15:21:02 UTC) #4
anujsharma
On 2014/10/07 15:21:02, sky wrote: > LGTM - but update your description. There is no ...
6 years, 2 months ago (2014-10-07 15:59:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633463003/1
6 years, 2 months ago (2014-10-07 16:01:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/76072) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/65420) android_aosp ...
6 years, 2 months ago (2014-10-07 16:05:42 UTC) #9
anujsharma
On 2014/10/07 16:05:42, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-08 03:15:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633463003/20001
6 years, 2 months ago (2014-10-08 03:16:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0cf104f4a56b3b28df69703ce5def9ae0e6a080d
6 years, 2 months ago (2014-10-08 03:38:46 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 03:39:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46c005518fa8fcc857dedf56107a9ebdd33a781d
Cr-Commit-Position: refs/heads/master@{#298650}

Powered by Google App Engine
This is Rietveld 408576698