Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 633463002: Rename ObjectAliveTrait::isAlive() to isHeapObjectAlive(). (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename ObjectAliveTrait::isAlive() to isHeapObjectAlive(). This method is only invoked by Visitor::isAlive() and never explicitly declared in "user code", so switch to a name less likely to conflict with what an object might otherwise provide. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/platform/heap/Handle.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/heap/Visitor.h View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
LGTM
6 years, 2 months ago (2014-10-06 08:48:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633463002/1
6 years, 2 months ago (2014-10-06 11:57:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30334)
6 years, 2 months ago (2014-10-06 15:12:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633463002/1
6 years, 2 months ago (2014-10-06 17:15:59 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 18:16:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183282

Powered by Google App Engine
This is Rietveld 408576698