Issue 63343003: Revert "Improvements in positions handling in optimizing compiler."

Issue 63343003: Revert "Improvements in positions handling in optimizing compiler." (Closed)

Created:
7 years, 1 month ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Improvements in positions handling in optimizing compiler." (r17765) Original issue: https://codereview.chromium.org/49203002/ TBR=vegorov Committed: https://code.google.com/p/v8/source/detail?r=17768

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -149 lines)			Patch
M	src/hydrogen.cc	View	7 chunks	+3 lines, -22 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	6 chunks	+4 lines, -125 lines	0 comments	Download
M	src/hydrogen-representation-changes.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

Apologies for reverting. You didn't seem to be online. Broke the win64 build: http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/6196/steps/compile/logs/stdio Like ...

7 years, 1 month ago (2013-11-14 21:44:20 UTC) #1

Apologies for reverting. You didn't seem to be online.

Broke the win64 build: 

http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/6196/steps/c...

Like this:

1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): error
C2220: warning treated as error - no 'object' file generated
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1125): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data
1>e:\b\build\slave\v8-win64\build\v8\src\hydrogen-instructions.h(1127): warning
C4244: 'return' : conversion from 'intptr_t' to 'int', possible loss of data

Message was sent while issue was closed.

Committed patchset #1 manually as r17768.

Expand Messages | Collapse Messages