Teach TurboFan to call vector-based ICs.

src/compiler/ast-graph-builder.h

Index: src/compiler/ast-graph-builder.h
diff --git a/src/compiler/ast-graph-builder.h b/src/compiler/ast-graph-builder.h
index 967b24bda13d32f33101068e2a2429fdd775b89c..1f0514b11cba76193dad3275c932b29a8749b489 100644
--- a/src/compiler/ast-graph-builder.h
+++ b/src/compiler/ast-graph-builder.h
@@ -52,6 +52,14 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor {
   void set_breakable(BreakableScope* brk) { breakable_ = brk; }
   void set_execution_context(ContextScope* ctx) { execution_context_ = ctx; }
 
+  LoadICFeedbackNode LoadNamedFeedback(int slot) const {

[Michael Starzinger, 2014/10/08 15:23:09]

As discussed offline: Haveing to deal with IC-related data structures here is a
smell. Can we instead just define a vecotr-slot-pair in js-operators.h that is a
pure data container without logic?

nit: This needs a comment. Also we should make it private (by placing it further
down).

[mvstanton, 2014/10/10 08:26:16]

Done.

+    return LoadICFeedbackNode(vector_, slot);
+  }
+
+  KeyedLoadICFeedbackNode LoadPropertyFeedback(int slot) const {
+    return KeyedLoadICFeedbackNode(vector_, slot);
+  }
+
   // Support for control flow builders. The concrete type of the environment
   // depends on the graph builder, but environments themselves are not virtual.
   typedef StructuredGraphBuilder::Environment BaseEnvironment;
@@ -82,7 +90,7 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor {
                                 BailoutId bailout_id);
   Node* BuildVariableDelete(Variable* var, BailoutId bailout_id,
                             OutputFrameStateCombine state_combine);
-  Node* BuildVariableLoad(Variable* var, BailoutId bailout_id,
+  Node* BuildVariableLoad(VariableProxy* proxy, BailoutId bailout_id,

[Michael Starzinger, 2014/10/08 15:23:09]

Either all the BuildVariableFoo helpers should work on Variable or on
VariableProxy, this arbitrary dichotomy smells.

As discussed offline: It might be better to instead pass the vector-slot-pair as
an argument.

[mvstanton, 2014/10/10 08:26:16]

Done.

                           ContextualMode mode = CONTEXTUAL);
 
   // Builders for accessing the function context.
@@ -118,6 +126,7 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor {
 
  private:
   CompilationInfo* info_;
+  Handle<TypeFeedbackVector> vector_;

[Michael Starzinger, 2014/10/08 15:23:09]

nit: Let's not start caching handles yet, this seems like premature
optimization.

[mvstanton, 2014/10/10 08:26:16]

Done.

   AstContext* ast_context_;
   JSGraph* jsgraph_;