Disable chartjson while investigating crbug.com/423034

Disable chartjson while investigating crbug.com/423034

BUG=423034
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292438

[sullivan, 2014-10-13 19:13:52]

sullivan@chromium.org changed reviewers:
+ qyearsley@chromium.org, stip@chromium.org, tonyg@chromium.org

[sullivan, 2014-10-13 19:13:53]

We've encountered some bugs with the new chartjson format:

* Supplemental revision columns missing: crbug.com/423034
* Page cycler results averaged instead of summed: crbug.com/422177
* Telemetry failures show as purple instead of red: crbug.com/422173
* "Important" test results not shown on buildbot status pages: crbug.com/422712

Because of bug 422177, if we submit this CL to disable --chartjson, the page
cycler results will go back from being averaged to being summed, showing the
perf sheriffs some bogus alerts.

I want to verify that's okay before submitting this.

[qyearsley, 2014-10-13 19:48:33]

On 2014/10/13 19:13:53, sullivan wrote:
> We've encountered some bugs with the new chartjson format:
> 
> * Supplemental revision columns missing: crbug.com/423034
> * Page cycler results averaged instead of summed: crbug.com/422177
> * Telemetry failures show as purple instead of red: crbug.com/422173
> * "Important" test results not shown on buildbot status pages:
crbug.com/422712
> 
> Because of bug 422177, if we submit this CL to disable --chartjson, the page
> cycler results will go back from being averaged to being summed, showing the
> perf sheriffs some bogus alerts.
> 
> I want to verify that's okay before submitting this.

I think it is OK to submit this. We should send an email to
perf-sheriffs@chromium.org to warn about expected changes to page_cycler results
(and it might be a good idea to put a note about that in this CL description in
case someone files a bug and a bisect finds this CL is responsible).

[qyearsley, 2014-10-13 19:48:43]

On 2014/10/13 19:48:33, qyearsley wrote:
> On 2014/10/13 19:13:53, sullivan wrote:
> > We've encountered some bugs with the new chartjson format:
> > 
> > * Supplemental revision columns missing: crbug.com/423034
> > * Page cycler results averaged instead of summed: crbug.com/422177
> > * Telemetry failures show as purple instead of red: crbug.com/422173
> > * "Important" test results not shown on buildbot status pages:
> crbug.com/422712
> > 
> > Because of bug 422177, if we submit this CL to disable --chartjson, the page
> > cycler results will go back from being averaged to being summed, showing the
> > perf sheriffs some bogus alerts.
> > 
> > I want to verify that's okay before submitting this.
> 
> I think it is OK to submit this. We should send an email to
> mailto:perf-sheriffs@chromium.org to warn about expected changes to
page_cycler results
> (and it might be a good idea to put a note about that in this CL description
in
> case someone files a bug and a bisect finds this CL is responsible).

lgtm

[sullivan, 2014-10-13 19:49:37]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:50:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633393003/1

[commit-bot: I haz the power, 2014-10-13 19:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:51:50]

Presubmit check for 633393003-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    build/scripts/slave/runtest.py

Presubmit checks took 61.7s to calculate.

[ghost stip (do not use), 2014-10-13 19:56:36]

lgtm

[sullivan, 2014-10-13 19:56:55]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:57:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633393003/1

[commit-bot: I haz the power, 2014-10-13 19:58:52]

Committed patchset #1 (id:1) as 292438

[sullivan, 2014-10-13 20:00:15]

On 2014/10/13 19:58:52, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as 292438

Sent mail to perf sheriffs.