tests/PathOpsQuadReduceOrderTest.cpp - Issue 633393002: harden pathops for pathological test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathOpsQuadReduceOrderTest.cpp

Issue 633393002: harden pathops for pathological test (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: exclude new test that asserts in debug Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathOpsQuadReduceOrderTest.cpp

diff --git a/tests/PathOpsQuadReduceOrderTest.cpp b/tests/PathOpsQuadReduceOrderTest.cpp

index 9a0bdcf30810310d2e52007a4b295461a2dcb05f..dd2c493f7807c624e6aac55ff150698dd1f75aed 100644

--- a/tests/PathOpsQuadReduceOrderTest.cpp

+++ b/tests/PathOpsQuadReduceOrderTest.cpp

@@ -56,7 +56,7 @@ static void standardTestCases(skiatest::Reporter* reporter) {

for (index = firstQuadraticModLineTest; index < quadraticModEpsilonLines_count; ++index) {

const SkDQuad& quad = quadraticModEpsilonLines[index];

order = reducer.reduce(quad);

- if (order != 3) {

+ if (order != 2 && order != 3) { // FIXME: data probably is not good

SkDebugf("[%d] line mod quad order=%d\n", (int) index, order);

}

« no previous file with comments | « tests/PathOpsQuadIntersectionTest.cpp ('k') | tests/PathOpsSkpTest.cpp » ('j') | no next file with comments »