Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 633373009: Mac Video Capture: Removed AVFoundation camera blacklisting. (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac Video Capture: Removed AVFoundation camera blacklisting. This blacklisting allowed certain cameras to be manipulated using the QTKit API side by side to the AVFoundation API. This is not needed anymore since the only blacklisted cameras, namely the Blackmagic ones, are manipulated via third_party Decklink SDK. Note that not all traces of blacklisting disappear: QTKit Blackmagic must avoid certain resolutions that would otherwise crash the browser (see http://crbug.com/396812). BUG=408493, 408089 TEST=After running Chrome, plug in a thunderbolt Blackmagic device, for instance an UltraStudio Mini. Wait 4 seconds or so, then enumerate devices, e.g. using http://goo.gl/r0lnFQ. There should be a number of Blackmagic/UltraStudio mini entries but no "QTKit " prefixed camera (those are the removed ones). Committed: https://crrev.com/aaa0642e2eef28c9aba84d8ec50fe8b40a269f42 Cr-Commit-Position: refs/heads/master@{#299026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M media/video/capture/mac/video_capture_device_factory_mac.mm View 3 chunks +5 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mcasas
vrk@ PTAL/OWNERS RS rsesek@: FYI/PTAL
6 years, 2 months ago (2014-10-09 12:21:19 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-09 13:50:52 UTC) #3
vrk (LEFT CHROMIUM)
lgtm
6 years, 2 months ago (2014-10-09 23:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633373009/1
6 years, 2 months ago (2014-10-09 23:11:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 00:37:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:38:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaa0642e2eef28c9aba84d8ec50fe8b40a269f42
Cr-Commit-Position: refs/heads/master@{#299026}

Powered by Google App Engine
This is Rietveld 408576698