Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 633373005: Use more flexible field trial control on resource prefetching for mobile web (Closed)

Created:
6 years, 2 months ago by Zhen Wang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, shishir+watch_chromium.org, kenjibaheux
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use more flexible field trial control on resource prefetching for mobile web The switches are integrated with the new predictive network actions unified preference. BUG=405690, 406203 Committed: https://crrev.com/e3f7c0ab35a4b452683bcad767d8d448f9ed072f Cr-Commit-Position: refs/heads/master@{#299316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -107 lines) Patch
M chrome/browser/predictors/resource_prefetch_common.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 6 chunks +124 lines, -97 lines 0 comments Download
A chrome/browser/predictors/resource_prefetch_common_unittest.cc View 1 chunk +332 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Zhen Wang
I change the field trial control to a more flexible version and integrate it with ...
6 years, 2 months ago (2014-10-08 17:50:51 UTC) #2
Bence
LGTM
6 years, 2 months ago (2014-10-10 20:07:35 UTC) #3
tburkard
lgtm Nice simplification.
6 years, 2 months ago (2014-10-13 08:33:55 UTC) #4
Shishir
On 2014/10/13 08:33:55, tburkard wrote: > lgtm > > Nice simplification. lgtm
6 years, 2 months ago (2014-10-13 16:34:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633373005/1
6 years, 2 months ago (2014-10-13 17:08:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 17:34:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 17:35:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f7c0ab35a4b452683bcad767d8d448f9ed072f
Cr-Commit-Position: refs/heads/master@{#299316}

Powered by Google App Engine
This is Rietveld 408576698