Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 633363002: Get rid of isolate state. (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of isolate state. it's not thread safe, and there are only initialized isolates now. BUG=none R=svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24466

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -105 lines) Patch
M src/api.cc View 12 chunks +1 line, -21 lines 0 comments Download
M src/heap/heap.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/isolate.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/isolate.cc View 1 6 chunks +39 lines, -52 lines 0 comments Download
M src/sampler.cc View 4 chunks +1 line, -4 lines 0 comments Download
M src/v8threads.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-08 09:34:20 UTC) #1
Sven Panne
lgtm
6 years, 2 months ago (2014-10-08 11:31:20 UTC) #2
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-08 11:52:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698