Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 633353002: Replace OVERRIDE with its C++11 counterparts in src/rlz (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE with its C++11 counterparts in src/rlz This step is a giant search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Committed: https://crrev.com/c8928f090195d262f9feea6c1b34e2b9326edb59 Cr-Commit-Position: refs/heads/master@{#298863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 1 chunk +15 lines, -15 lines 0 comments Download
M rlz/lib/financial_ping.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/rlz_lib_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.h View 1 chunk +15 lines, -15 lines 0 comments Download
M rlz/test/rlz_test_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
M rlz/win/lib/rlz_value_store_registry.h View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 2 months ago (2014-10-08 07:34:36 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years, 2 months ago (2014-10-08 18:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633353002/1
6 years, 2 months ago (2014-10-09 05:41:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16546)
6 years, 2 months ago (2014-10-09 05:50:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633353002/1
6 years, 2 months ago (2014-10-09 13:24:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as c5b5560a88d5af833c8488b2a299a8145d6f1f1d
6 years, 2 months ago (2014-10-09 13:28:38 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:29:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8928f090195d262f9feea6c1b34e2b9326edb59
Cr-Commit-Position: refs/heads/master@{#298863}

Powered by Google App Engine
This is Rietveld 408576698