Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 633333003: Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths. (Closed)

Created:
6 years, 1 month ago by earthdok
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use <(DEPTH) instead of <(PRODUCT_DIR)/../../ for sanitizer blacklist paths. It's not correct to assume that the build directory is two levels below src/. BUG=427202 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/dcb216595d483246a0979849f44a993f4d432c7f Cr-Commit-Position: refs/heads/master@{#301379}

Patch Set 1 #

Patch Set 2 : use absolute paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/common.gypi View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
earthdok
6 years, 1 month ago (2014-10-27 14:24:38 UTC) #1
Alexander Potapenko
On 2014/10/27 14:24:38, earthdok wrote: LGTM
6 years, 1 month ago (2014-10-27 16:37:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633333003/20001
6 years, 1 month ago (2014-10-27 16:38:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 16:40:52 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dcb216595d483246a0979849f44a993f4d432c7f Cr-Commit-Position: refs/heads/master@{#301379}
6 years, 1 month ago (2014-10-27 16:41:40 UTC) #7
Fabrice (no longer in Chrome)
6 years, 1 month ago (2014-10-27 16:51:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/680913004/ by fdegans@chromium.org.

The reason for reverting is: This broke Windows bots, see
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bui...
There is no pwd command on windows..

Powered by Google App Engine
This is Rietveld 408576698