Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Side by Side Diff: content/renderer/pepper/v8object_var.h

Issue 633303002: Replace FINAL and OVERRIDE with their C++11 counterparts in content/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 5 #ifndef CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
6 #define CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 6 #define CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 15 matching lines...) Expand all
26 // reference. If two different modules reference the same v8 object (like the 26 // reference. If two different modules reference the same v8 object (like the
27 // "window" object), then there will be different V8ObjectVar's (and hence 27 // "window" object), then there will be different V8ObjectVar's (and hence
28 // PP_Var IDs) for each module. This allows us to track all references owned by 28 // PP_Var IDs) for each module. This allows us to track all references owned by
29 // a given module and free them when the plugin exits independently of other 29 // a given module and free them when the plugin exits independently of other
30 // plugins that may be running at the same time. 30 // plugins that may be running at the same time.
31 class CONTENT_EXPORT V8ObjectVar : public Var { 31 class CONTENT_EXPORT V8ObjectVar : public Var {
32 public: 32 public:
33 V8ObjectVar(PP_Instance instance, v8::Handle<v8::Object> v8_object); 33 V8ObjectVar(PP_Instance instance, v8::Handle<v8::Object> v8_object);
34 34
35 // Var overrides. 35 // Var overrides.
36 virtual V8ObjectVar* AsV8ObjectVar() OVERRIDE; 36 virtual V8ObjectVar* AsV8ObjectVar() override;
37 virtual PP_VarType GetType() const OVERRIDE; 37 virtual PP_VarType GetType() const override;
38 38
39 // Returns the underlying v8 object corresponding to this V8ObjectVar. This 39 // Returns the underlying v8 object corresponding to this V8ObjectVar. This
40 // should only be used on the stack. 40 // should only be used on the stack.
41 v8::Local<v8::Object> GetHandle() const; 41 v8::Local<v8::Object> GetHandle() const;
42 42
43 // Notification that the instance was deleted, the internal reference will be 43 // Notification that the instance was deleted, the internal reference will be
44 // zeroed out. 44 // zeroed out.
45 void InstanceDeleted(); 45 void InstanceDeleted();
46 46
47 // Possibly NULL if the object has outlived its instance. 47 // Possibly NULL if the object has outlived its instance.
48 content::PepperPluginInstanceImpl* instance() const { return instance_; } 48 content::PepperPluginInstanceImpl* instance() const { return instance_; }
49 49
50 // Helper function that converts a PP_Var to an object. This will return NULL 50 // Helper function that converts a PP_Var to an object. This will return NULL
51 // if the PP_Var is not of object type or the object is invalid. 51 // if the PP_Var is not of object type or the object is invalid.
52 static scoped_refptr<V8ObjectVar> FromPPVar(PP_Var var); 52 static scoped_refptr<V8ObjectVar> FromPPVar(PP_Var var);
53 53
54 private: 54 private:
55 virtual ~V8ObjectVar(); 55 virtual ~V8ObjectVar();
56 56
57 content::PepperPluginInstanceImpl* instance_; 57 content::PepperPluginInstanceImpl* instance_;
58 58
59 v8::Persistent<v8::Object> v8_object_; 59 v8::Persistent<v8::Object> v8_object_;
60 60
61 DISALLOW_COPY_AND_ASSIGN(V8ObjectVar); 61 DISALLOW_COPY_AND_ASSIGN(V8ObjectVar);
62 }; 62 };
63 63
64 } // ppapi 64 } // ppapi
65 65
66 #endif // CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 66 #endif // CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
OLDNEW
« no previous file with comments | « content/renderer/pepper/v8_var_converter_unittest.cc ('k') | content/renderer/pepper/video_decoder_shim.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698