content/browser/service_worker/service_worker_database.cc - Issue 633273002: Added quota client for serviceworker. Enables 'clear past <time> data'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database.cc

Issue 633273002: Added quota client for serviceworker. Enables 'clear past <time> data'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logic to Core Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_wrapper.cc ('K') | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | content/browser/service_worker/service_worker_quota_client.h » ('j') | content/browser/service_worker/service_worker_quota_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_database.cc

diff --git a/content/browser/service_worker/service_worker_database.cc b/content/browser/service_worker/service_worker_database.cc

index 0bd5bbc09fd3012698773898a07a069ef2a458b5..f208cef52e1f26001753de32692c6255b17833b8 100644

--- a/content/browser/service_worker/service_worker_database.cc

+++ b/content/browser/service_worker/service_worker_database.cc

@@ -215,6 +215,9 @@ ServiceWorkerDatabase::Status ParseRegistrationData(

if (!scope_url.is_valid() ||

!script_url.is_valid() ||

scope_url.GetOrigin() != script_url.GetOrigin()) {

+ DLOG(ERROR) << "Scope URL '" << data.scope_url() << "' and/or script url '"

jsbell 2014/10/13 20:54:25 Why add this during this CL?

dmurph 2014/10/14 00:16:31 I ran into this during testing, it should make it

+ << data.script_url()

+ << "' are invalid or have mismatching origins.";

return ServiceWorkerDatabase::STATUS_ERROR_CORRUPTED;

}