Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 633263002: Mojo: Combine mojo/edk/{system,embedder}/PRESUBMIT.py. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Combine mojo/edk/{system,embedder}/PRESUBMIT.py. Instead, have a mojo/edk/PRESUBMIT.py. Format mojo/edk/test/. Also reformat mojo/edk/{system,embedder}/ (to match current clang-format output). R=sky@chromium.org Committed: https://crrev.com/b247579e8a2339c59884aa4b5ef3dcb00d9aa9f8 Cr-Commit-Position: refs/heads/master@{#298603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -80 lines) Patch
A + mojo/edk/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
D mojo/edk/embedder/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/edk/system/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/memory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 1 chunk +12 lines, -10 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/test/run_all_unittests.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/test/test_support_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/test/test_support_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/test_utils_win.cc View 5 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-07 21:48:20 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-10-07 22:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633263002/1
6 years, 2 months ago (2014-10-07 22:30:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2348124320dca12d44a4c8a3da598ba3259a31d2
6 years, 2 months ago (2014-10-07 23:14:09 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 23:15:04 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b247579e8a2339c59884aa4b5ef3dcb00d9aa9f8
Cr-Commit-Position: refs/heads/master@{#298603}

Powered by Google App Engine
This is Rietveld 408576698