[Easy Unlock] Port the BluetoothConnectionFinder class to native code.

[Easy Unlock] Port the BluetoothConnectionFinder class to native code.

A couple of pieces are left as TODOs for future CLs:
  * Porting the "seek device by Bluetooth address" feature.
  * Wiring up a screen lock state accessor.

BUG=420946
TEST=components_unittests
R=tengs@chromium.org

Committed: https://crrev.com/ac4df1c4df6fdc7c771eb0bdeb15dbd6f2dbb98c
Cr-Commit-Position: refs/heads/master@{#299415}

[Tim Song, 2014-10-10 18:44:39]

LGTM

I wonder if it's still a good idea to couple the lock screen state with the
BluetoothConnectionFinder. IIRC, this was originally due to a last minute
request to only poll on the lock screen.

We should probably add a new state to the Controller to distinguish between
lock/unlocked states. There are additional features (such as proximity) which
may require this distinction as well.

https://codereview.chromium.org/633253002/diff/1/components/proximity_auth/bl...
File components/proximity_auth/bluetooth_connection_finder_unittest.cc (right):

https://codereview.chromium.org/633253002/diff/1/components/proximity_auth/bl...
components/proximity_auth/bluetooth_connection_finder_unittest.cc:61: void
OnConnectionFound(scoped_ptr<Connection> connection) {
If you move this to the test fixture, you can have a callback member variable to
save the code duplication of doing base::Bind() in every test.

[Ilya Sherman, 2014-10-11 00:31:23]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-10-11 00:31:34]

On 2014/10/10 18:44:39, Tim Song wrote:
> I wonder if it's still a good idea to couple the lock screen state with
> the BluetoothConnectionFinder. IIRC, this was originally due to a last
> minute request to only poll on the lock screen.
> 
> We should probably add a new state to the Controller to distinguish
> between lock/unlocked states. There are additional features (such as
> proximity) which may require this distinction as well.

Good call.  I've added a TODO to implement screen lock state tracking in the
controller, and removed all other references to the screen lock state from this
CL.

https://codereview.chromium.org/633253002/diff/1/components/proximity_auth/bl...
File components/proximity_auth/bluetooth_connection_finder_unittest.cc (right):

https://codereview.chromium.org/633253002/diff/1/components/proximity_auth/bl...
components/proximity_auth/bluetooth_connection_finder_unittest.cc:61: void
OnConnectionFound(scoped_ptr<Connection> connection) {
On 2014/10/10 18:44:39, Tim Song wrote:
> If you move this to the test fixture, you can have a callback member variable
to
> save the code duplication of doing base::Bind() in every test.

Done.

[commit-bot: I haz the power, 2014-10-11 00:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633253002/40001

[commit-bot: I haz the power, 2014-10-11 01:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-11 01:40:13]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Ilya Sherman, 2014-10-14 00:05:38]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-14 00:06:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633253002/320001

[commit-bot: I haz the power, 2014-10-14 01:31:10]

Committed patchset #4 (id:320001)

[commit-bot: I haz the power, 2014-10-14 01:32:17]

Patchset 4 (id:??) landed as
https://crrev.com/ac4df1c4df6fdc7c771eb0bdeb15dbd6f2dbb98c
Cr-Commit-Position: refs/heads/master@{#299415}

[yoichio, 2014-10-14 03:37:37]

A revert of this CL (patchset #4 id:320001) has been created in
https://codereview.chromium.org/651073002/ by yoichio@chromium.org.

The reason for reverting is: Causes compile failure on mac:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/b....